Skip to content

chore(deps): upgrade Rslib to v1.0.0-beta.0#43

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-upgrade-rslib-1-beta
Jul 15, 2026
Merged

chore(deps): upgrade Rslib to v1.0.0-beta.0#43
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-upgrade-rslib-1-beta

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR upgrades Rslib to v1.0.0-beta.0 to adopt its latest pre-release behavior and compatibility updates.

When define.lib is omitted, Rstack now returns an empty Rslib config and relies on Rslib's new default library output instead of injecting lib: [{}].

Related Links

@chenjiahan chenjiahan merged commit d48ba4d into main Jul 15, 2026
3 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/chore-upgrade-rslib-1-beta branch July 15, 2026 09:46
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9276b376-e320-4847-89e7-ff4a6b4f7a65

📥 Commits

Reviewing files that changed from the base of the PR and between 98b7501 and a439d3e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • packages/rstack/src/rslibConfig.ts
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

The configuration loader now returns {} when no lib configuration is supplied, instead of creating a default lib array. The workspace catalog also updates @rslib/core from ~0.23.2 to ~1.0.0-beta.0.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: upgrading Rslib to v1.0.0-beta.0.
Description check ✅ Passed The description matches the changeset and explains the upgrade plus the config behavior change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/chore-upgrade-rslib-1-beta

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a439d3e8a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if (!libConfig) {
// TODO: should allow empty object to be returned
return { lib: [{}] };
return {};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't treat explicit falsy lib configs as omitted

When a JavaScript config calls define.lib(null) or define.lib(false), configs.lib is explicitly present but this path now returns the omitted-config default {} and lets Rslib build the default library instead of validating the bad value. Since this upgrade relies on Rslib's new distinction between omitted lib and invalid explicit values, check for undefined/presence rather than all falsy values so invalid configs still fail fast.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant