Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces initial user authentication/session support to the StudyMate FastAPI app, and begins wiring user identity into the persistence layer.
Changes:
- Added
/loginand/logoutendpoints that create/delete server-side sessions and set asession_idcookie. - Added/extended SQLAlchemy models to include
User,UserSession, and user foreign keys on existing records. - Tightened schema validation for user login fields by using
EmailStr.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| schemas.py | Adds EmailStr typing and organizes request schemas for chat/quiz/user flows. |
| main.py | Introduces login/logout routes with cookie-based session handling and imports new models/schemas. |
| db/models.py | Adds User/UserSession models and adds user foreign keys to existing models. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+74
to
+79
| # Verify password | ||
| if user.password != request.password: | ||
| raise HTTPException( | ||
| status_code=401, | ||
| detail="Invalid email or password" | ||
| ) |
Comment on lines
+94
to
+99
| response.set_cookie( | ||
| key="session_id", | ||
| value=session_id, | ||
| httponly=True, | ||
| samesite="lax" | ||
| ) |
| @app.post("/logout") | ||
| def logout( | ||
| response: Response, | ||
| session_id: str = Cookie(None), |
Comment on lines
+56
to
+61
| @app.post("/login") | ||
| def login( | ||
| request: UserLogin, | ||
| response: Response, | ||
| db: Session = Depends(get_db) | ||
| ): |
Comment on lines
9
to
11
| id = Column(Integer, primary_key=True, index=True) | ||
| user_id = Column(Integer, ForeignKey("users.id")) # NEW | ||
| topic = Column(String) |
Comment on lines
+30
to
+33
| id = Column(Integer, primary_key=True, index=True) | ||
| session_id = Column(String, unique=True, index=True) | ||
| user_id = Column(Integer, ForeignKey("users.id")) | ||
| created_at = Column(DateTime, default=datetime.utcnow) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.