Fix unquote-splicing lists within quasiquote - #219
Open
shawwn wants to merge 1 commit into
Open
Conversation
- The following expression now correctly returns '(x y z):
(eval `(let (a 'y b 'z) `(x ,,@'(a b))))
(It was returning '(x y) since (unquote a b) was ignoring b.)
- MAP now supports splicing. E.g.:
> (define-global spliced (x)
(if (hd? x '%splice) x
(obj? x) `(%splice ,x)
x))
> (define-global flatten (l)
(while (first obj? l)
(set l (map spliced l)))
l)
> (flatten '((1 2) 3 (4 5 (6))))
(1 2 3 4 5 6)
> (define-global intersperse (a bs)
(tl (map (fn (x) `(%splice (,a ,x))) bs)))
> (apply cat (intersperse ", " '(foo bar baz)))
"foo, bar, baz"
Contributor
Author
|
I'm not sure this PR is worthwhile, but the root problem was that I couldn't implement pg's continuation-passing macros: Specifically, the This unquote problem is also present in arc (but interestingly, common lisp handles it) so perhaps this "bug" could be considered a feature for simplicity. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

(It was returning '(x y) since (unquote a b) was ignoring b.)