Allow 1 volunteer to submit report by NicholasT1 · Pull Request #103 · seanlim/primap

NicholasT1 · 2026-06-22T13:38:13Z

Changes

Add steps and migrations for easier setup of local supabase instance
Remove user_id column from observation table
Remove queries using user_id for observation table
Remove other reports in group report view

Note

DB migrations for this PR have not been run yet on shared Supabase remote since it is a breaking change (Will run after this is merged)
Can test by starting and connecting to local Supabase instance (It should start without issues, with seeded data that is copied from our shared Supabase remote), this instance will have all the DB migrations for this PR

After this PR

Only 1 report will exist for each slot (Just retaining the earliest created one for each slot)
All users will see and edit the same report (to be fixed in Set 1st user who accesses the report as submitter #105)

Closes #104

NicholasT1 · 2026-07-07T14:34:56Z

seeded data obtained after db_dump on our shared supabase remote, then applying the migrations from this PR

seanlim · 2026-07-09T07:22:57Z

Hi @NicholasT1, can you rebase on master?

seanlim · 2026-07-16T09:56:06Z

Verified that migrations run successfully and data is seeded properly

ngkhengyang

I think it will be better if the PR addresses both #104 and #105 at the same time since both are closely related and involve database changes. Meanwhile, it avoids leaving extra code comments (for example)

ngkhengyang · 2026-07-15T10:32:43Z

+
+### Prerequisites
+
+- Docker Desktop (must be running)


Attempted to run local supabase and as another prerequisite required, google client id and secret are required as part of google auth provider. The supabase/config.toml file needs to be configured accordingly with those keys as well.

I don't think it's super necessary for now since we can just login with email directly and the google login flow shouldn't need testing locally

ngkhengyang · 2026-07-15T14:46:25Z

  submittedAt: string
-  reporters: string[]
-  submittedCount: number
+  // submittedBy: string


Is this comment needed?

ngkhengyang · 2026-07-15T19:50:33Z

    : { data: [] }

  const currentRoundSlotIds = (currentRoundSlots || []).map((slot) => slot.id)
+  const currentRoundUserSlotIds = currentRoundSlotIds.filter((id) => userSlotIds.includes(id))


Instead of filtering here, maybe you can optimize this a little by adding a .in('slot_id', userSlotIds) clause in the db query for currentRoundSlots? db query is more optimized for this.

ngkhengyang · 2026-07-15T19:54:11Z

-      return next
-    })
-  }
+  const myObservation = observations


Is this re-assignment needed?

ngkhengyang · 2026-07-15T19:55:28Z

    roundName: string
  }
-  observations: ObservationData[]
+  observations: ObservationData


Suggested change

observations: ObservationData

observation: ObservationData

Perhaps renaming the prop into a singular form (or myObservation) may be more appropriate?

ngkhengyang · 2026-07-16T08:12:54Z

+    .select('user_id, status, profiles:user_id(full_name, email)')
+    .eq('slot_id', data.slot_id)
+
+  const membership = (memberships || []).find((m) => m.status === 'ACTIVE') as { user_id: string; profiles: { full_name: string | null; email: string } | null } | undefined


Instead of one of the active members, I think this can display all active memberships instead since we are going under the assumption where all of them contributed to one single report (you may indicated who submitted the report when you handle #105 )

ngkhengyang · 2026-07-16T08:57:39Z

  },
 } as const

-// Convenience type aliases used throughout the app. These are pure type


As far as I'm aware, there are several files that referenced imports for these types, so the deletion of these convenience type aliases will create compiler errors (use npx tsc --noEmit to check).

seanlim · 2026-07-16T10:48:36Z

@NicholasT1 this PR is kinda huge, you might want to cherry pick the local supabase dev setup stuff (base migrations, seed, readme and config changes) into a separate branch so we can get that merged first!

NicholasT1 · 2026-07-19T06:03:29Z

I think it will be better if the PR addresses both #104 and #105 at the same time since both are closely related and involve database changes. Meanwhile, it avoids leaving extra code comments (for example)

I think this PR is already quite big and for now, I might not have much time to work on this. Not ideal to leave comments but I feel if another team member has the bandwidth to work on #105, it would be preferable to waiting for me to eventually finish it.

NicholasT1 force-pushed the feat/revamp-reports branch from 00c7b57 to 75e6f14 Compare June 30, 2026 12:58

NicholasT1 commented Jul 5, 2026

View reviewed changes

Comment thread supabase/migrations/20260719122827_update_join_slot_with_observation.sql

NicholasT1 commented Jul 5, 2026

View reviewed changes

Comment thread supabase/migrations/20260719122751_change_observation_schema.sql

NicholasT1 commented Jul 7, 2026

View reviewed changes

NicholasT1 marked this pull request as ready for review July 7, 2026 14:51

NicholasT1 self-assigned this Jul 7, 2026

NicholasT1 force-pushed the feat/revamp-reports branch from 675ef0a to ddd8ba7 Compare July 9, 2026 15:50

seanlim reviewed Jul 16, 2026

View reviewed changes

Comment thread supabase/seed.sql

seanlim Jul 16, 2026

Copy link
Copy Markdown

Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that migrations run successfully and data is seeded properly

ngkhengyang requested changes Jul 16, 2026

View reviewed changes

NicholasT1 added 14 commits July 19, 2026 20:23

Add migration to change observation table

28af43c

Add migration for changes to db function

2a5ac2f

Remove query by user_id from report pages

f39e98a

Remove group reports

1bae6bb

Update sql script

0898de9

Update policies for removal of user_id column

ce603d3

Change queries for observation table

23aed04

Remove user Id from query for observation table

c9e4e4b

Fix tests

7b519c3

Add todo

1da7efe

Add instructions for local dev

8b1d047

Autogenerated types by supabase

9501a71

Remove userid

86265c7

Rename migration files

b20608f

NicholasT1 force-pushed the feat/revamp-reports branch from ddd8ba7 to b20608f Compare July 19, 2026 12:36

Conversation

NicholasT1 commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Note

After this PR

Uh oh!

Uh oh!

Uh oh!

NicholasT1 Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seanlim commented Jul 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ngkhengyang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seanlim commented Jul 16, 2026

Uh oh!

NicholasT1 commented Jul 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NicholasT1 commented Jun 22, 2026 •

edited

Loading

NicholasT1 Jul 7, 2026 •

edited

Loading