Close SSH-stack and stdlib CVEs (x/crypto v0.52.0, Go 1.25.12)#813
Open
itsouvalas wants to merge 3 commits into
Open
Close SSH-stack and stdlib CVEs (x/crypto v0.52.0, Go 1.25.12)#813itsouvalas wants to merge 3 commits into
itsouvalas wants to merge 3 commits into
Conversation
Clears the eight SSH advisories that govulncheck reports as symbol-reachable at v0.50.0: CVE-2026-39828, -39829, -39830, -39831, -39834, -39835, -46595 and -46597. Five further advisories in the same release are not in this build's call graph, since ssh/agent and ssh/knownhosts are not vendored. Pulls x/net, x/sys, x/term and x/text forward as transitive requirements. Build, unit tests and the 398-test API suite are green, and go vet reports only the three pre-existing warnings.
Nothing exercised the core->agent SSH channel end to end with the production client config, though shield imports golang.org/x/crypto/ssh first-party as both server (shield-agent) and client (core). A bump can pass build, unit tests and the API suite while silently altering the negotiated channel. Adds agent/xcrypto_probe_test.go: six go-test probes that stand up the real shield-agent, drive a task through core's own client path, and pin the negotiated KEX, host key, cipher and MAC as a default-on drift gate. An algorithm-inventory check catches a dropped-algorithm regression that a matched-version round trip cannot see. Exposes core.DefaultLegacyAgentMACs so the probe asserts core's real MAC list rather than a copy that could drift. Behaviour is unchanged.
The go directive moves from 1.25.5 to 1.25.12, closing three residual DoS advisories that a 1.25.5 build leaves open -- GO-2026-4977 and -4986 in net/mail, -4342 in archive/zip, all fixed by go1.25.10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A security patch over v9.0.1, closing the reachable SSH-stack and
standard-library advisories and adding a probe that guards the SSH
channel against future dependency drift.
golang.org/x/crypto v0.50.0 → v0.52.0. SHIELD imports
golang.org/x/crypto/ssh first-party in both roles — the shield-agent is
an SSH server, core is the client — so these are reachable. Clears eight
advisories: CVE-2026-39828, -39829, -39830, -39831, -39834, -39835,
-46595, -46597.
Go build floor 1.25.5 → 1.25.12. Closes three stdlib DoS advisories:
GO-2026-4977 and -4986 (net/mail) and -4342 (archive/zip).
SSH-channel probe (
agent/xcrypto_probe_test.go). Stands up the realshield-agent and drives a task through core's own client path, asserting
the handshake and round-trip and pinning the negotiated crypto — nothing
else exercises this channel end to end with the production client config.