Feature/prd 504 Remove routing bridge between MapView and native SDK by adrian-situm · Pull Request #647 · situmtech/react-native

adrian-situm · 2026-07-20T07:54:10Z

No description provided.

Automatic merge into master to Release 3.18.6

Automatic merge into master to Release 3.18.7

Automatic merge into master to Release 3.18.8

Automatic merge into master to Release 3.18.9

Automatic merge into master to Release 3.18.10

Automatic merge into master to Release 3.18.11

Automatic merge into master to Release 3.18.12

Automatic merge into master to Release 3.18.13

Automatic merge into master to Release 3.18.14

Automatic merge into master to Release 3.18.15

Automatic merge into master to Release 3.18.16

Automatic merge into master to Release 3.18.17

Automatic merge into master to Release 3.18.18

Automatic merge into master to Release 3.18.19

Automatic merge into master to Release 3.18.20

Automatic merge into master to Release 3.18.21

Automatic merge into master to Release 3.18.22

Automatic merge into master to Release 3.18.23

Automatic merge into master to Release 3.18.24

Automatic merge into master to Release 3.18.25

Update version to 3.18.25

Automatic merge into master to Release 3.18.26

Update version to 3.18.26

…y on the url

adrian-situm · 2026-07-20T09:08:44Z

            const receivedError = internalCall.get<Error>();
            dispatch(setError(receivedError));
            break;
-          case InternalCallType.NAVIGATION_START:


Aquí llegaban los mensajes que enviaba el InternalCall, también se eliminan porque ya no se desea informar al viewer de estos cambios

adrian-situm · 2026-07-20T09:17:07Z

    );
  }

-  const calculateRoute = async (


Esta lógica era llamada por el MapView cuando recibía mensajes del viewer relacionados con la navegación y las rutas

adrian-situm · 2026-07-20T09:37:15Z

-    },
-    setNavigation: (state: State, payload: State["navigation"]) => {
-      return { ...state, navigation: payload };
-    },


Se utilizaban por el bridge para actualizar el estado de la store al hacer ruta y navegación por medio del sdk

adrian-situm · 2026-07-20T09:40:04Z

  currentBuilding: undefined,
  pois: [],
-  directions: undefined,
-  navigation: undefined,


Desde que se cambio el viewer para calcular las rutas desde javascript, esto se queda siempre en undefined. Ojo que si algún cliente los tenía en el código (aunque ya no funcionaban) podría lanzar error de typescript

Si se rompe compatibilidade hai que ter coidado. Eu deprecaría en primeiro lugar e nunha release posterior eliminaría. É unha putada, pero é o proceso a seguir.
@fsvilas que opinas?
Certo é que non creo que nadie acceda a esto...

Si eu marcaria como deprecada e indicaria que nunca vai recibir ningún valor, pero que se manten para non romper compatibilidad.
Se fixeramos nun futuro proximo un release que cambie o major (guiño, guiño), sí que se podería eliminar.

adrian-situm · 2026-07-20T09:40:55Z

-export const selectNavigation = (state: State) => {
-  return state.navigation;
-};
-


Se ha borrado el state.directions y state.navigation, no tiene sentido mantener los selects

O mismo que arriba.

Sep, deixaria os métodos inda que non fagan nada e marcariaos como deprecados

adrian-situm · 2026-07-20T09:56:07Z

  cancelNavigation: () => void;
-  setOnDirectionsRequestInterceptor: (params: {
-    onDirectionsRequestInterceptor: OnDirectionsRequestInterceptor;
-  }) => void;


Esto era una función que cambiaba un parámetro del MapView para guardar un Interceptor. Este Interceptor era una función a la que calculateRoute llamaba para modificar o capturar la información de la ruta

Igual: tecnicamente é unha función pública da API, primeiro habería que deprecala e despois eliminala.
Nadie debería estar usando esto... non sei que pensar. @fsvilas ?

adrian-situm · 2026-07-20T10:08:29Z

-    ),
-  );
-};
-


Se utilizaban exclusivamente en calculateRoute

adrian-situm · 2026-07-20T10:16:38Z

  // Navigation
-  navigation: (navigation: Navigation) => {
-    return mapperWrapper(`navigation.${navigation.status}`, navigation);
-  },


Estas eran funciones que convertían un objeto en un mensaje para el viewer. El viewer ya no capta estos mensajes, así que se borran.

adrian-situm · 2026-07-20T10:18:48Z

-      navigation,
-      calculateRoute,
-      startNavigation,
-      stopNavigation,


Se han borrado estos estados y funciones de la store, sincronizaban la navegación y rutas del sdk con el viewer

adrian-situm · 2026-07-20T10:20:02Z

  ) => {
    const webViewRef = useRef<WebView>(null);
-    const [_onDirectionsRequestInterceptor, setInterceptor] =
-      useState<OnDirectionsRequestInterceptor>();


El Interceptor permitía modificar los valores de una ruta antes de calcularse. Ya no se usa el sdk para calcularse así que no tiene sentido dejarlo.

adrian-situm · 2026-07-20T10:21:23Z

-
-      sendMessageToViewer(webViewRef.current, ViewerMapper.route(directions));
-    }, [directions, mapLoaded]);
-


Enviaban mensajes al viewer cuando la navegación o ruta de la store cambiaban. Se borraron estos valores de la store, así que de aquí también.

adrian-situm · 2026-07-20T10:28:04Z

-  /** Point to, where the route should end */
-  to: Point | Poi;
-} & DirectionsOptions;
-


Solo se usaba en createDirectionsRequest y en el Interceptor, ambos eliminados

Esto non estou convencido de que poidamos eliminalo:

Pertence á API pública, por tanto un cliente podería estar usándoo aínda que nós non o fagamos como tal.

Probablemente tería sentido engadir unha sobrecarga de requestDirections que reciba como parámetro este tipo.

É unha cousa rara porque como di Roi despois requestDirections:
static requestDirections = ( building: Building, from: Point | Location, to: Point | Poi, directionOptions?: DirectionsOptions, ) => { return promiseWrapper<Directions>(({ onSuccess, onError }) => { const params = [building, from, to, directionOptions || {}]; RNCSitumPlugin.requestDirections(params, onSuccess, onError); }); };
non usa ese obxeto.
Como di Roi eu sobrecargaria o metodo para usalo e incluso poderia valorarse deprecar o antigo

Lo estuve mirando y parece que habría que hacer cambios en la implementación nativa. De momento lo reintroduzco y dejo como está, si queréis lo podemos mirar.

adrian-situm · 2026-07-20T12:30:38Z

-          "Situm > hook > Navigation on course, poi category selection is unavailable",
-        );
-        return;
-      }


SitumPlugin.navigationIsRunning() comprueba si el SDK está utilizando la navegación, como ya no va sincronizado con el viewer no tiene usarlo aquí

adrian-situm · 2026-07-20T12:34:47Z

-        },
        cancelNavigation(): void {
          if (!webViewRef.current) return;
-          stopNavigation();


stopNavigation detenía la navegación en el SDK y actualizaba la store, esto se borra y se deja el sendMessageToViewer, que es el método moderno, para que se pueda seguir deteniendo la navegación por medio de esta función

…ning in the SDK

R-lagoman · 2026-07-21T10:06:53Z

-  /** Point to, where the route should end */
-  to: Point | Poi;
-} & DirectionsOptions;
-


Esto non estou convencido de que poidamos eliminalo:

Pertence á API pública, por tanto un cliente podería estar usándoo aínda que nós non o fagamos como tal.

Probablemente tería sentido engadir unha sobrecarga de requestDirections que reciba como parámetro este tipo.

R-lagoman · 2026-07-21T10:07:48Z


 /**
- * Available accessibility modes used in the {@link DirectionsRequest}.
+ * Available accessibility modes used when calculating routes.


Aquí creo que había unha confusión, o tipo correcto era DirectionsOptions, non DirectionsRequest (un está dentro do outro, é un pouco confuso)

Bien visto, lo cambio

R-lagoman · 2026-07-21T10:10:21Z

 };

 const _internalNavigationProgressCallback = (progress: NavigationProgress) => {
-  internalMethodCallMapDelegate(


Ten sentido manter a callback interna? Non se podería eliminar e usar directamente a callback de cliente? Igual para os casos de abaixo.

Claro, aplicaré el cambio

R-lagoman · 2026-07-21T10:16:19Z

  currentBuilding: undefined,
  pois: [],
-  directions: undefined,
-  navigation: undefined,


Si se rompe compatibilidade hai que ter coidado. Eu deprecaría en primeiro lugar e nunha release posterior eliminaría. É unha putada, pero é o proceso a seguir.
@fsvilas que opinas?
Certo é que non creo que nadie acceda a esto...

R-lagoman · 2026-07-21T10:17:53Z

-export const selectNavigation = (state: State) => {
-  return state.navigation;
-};
-


O mismo que arriba.

R-lagoman · 2026-07-21T10:20:15Z

  cancelNavigation: () => void;
-  setOnDirectionsRequestInterceptor: (params: {
-    onDirectionsRequestInterceptor: OnDirectionsRequestInterceptor;
-  }) => void;


Igual: tecnicamente é unha función pública da API, primeiro habería que deprecala e despois eliminala.
Nadie debería estar usando esto... non sei que pensar. @fsvilas ?

R-lagoman · 2026-07-21T10:20:30Z

- * This interface allows you to modify all the parameters in the DirectionRequest used by the MapViewer to calculate the route.
- * To use this you will need to load the MapView and once it ends loading use the MapViewRef that you obtain an call setOnDirectionsRequestInterceptor(interceptor)
- */
-export interface OnDirectionsRequestInterceptor {


Máis do mismo.

R-lagoman · 2026-07-21T10:21:32Z

  selectPoi: (poiId: number | null) => {
    return mapperWrapper(`cartography.select_poi`, { identifier: poiId });
  },
+  deselectPoi: () => {


Este método existe nalgunha outra plataforma (ex. flutter)? Está ben, pero é API pública e si existe debe chamarse igual, usarse igual, etc.

Esto lo acabo de meter hace unos minutos porque haciendo el plan de prueba descubrí que el deselectPoi que había en el MapView no funcionaba. No he añadido ninguna interfaz publica, solo he arreglado una función imperativa del MapView que no funcionaba.

…e documentation

… running

fsvilas · 2026-07-22T10:42:20Z

-  navigation?: Navigation;
-  error?: Error;
-}
-


Entendo que o mesmo tamen para estos tres

fsvilas · 2026-07-22T10:42:39Z

-  destinationIdentifier: string;
-  destinationCategory: string;
-  identifier: string;
-};


fsvilas · 2026-07-22T10:44:35Z

+
+### Removed
+
+- Removed routing and navigation bridge between MapView and native SDK.


Explicar esto mellor, esto faise porque agora o mapView nunca vai usar a navegación do sdk

R-lagoman

Aprobada, pero porfa revisa ese último comentario que puxen.

R-lagoman · 2026-07-22T13:43:20Z

@@ -1,17 +1,3 @@
-export enum NavigationStatus {


Estame vindo á cabeza que esta enum quizais estivera aí unicamente para ser usada desde o lado cliente, para que dispoña dun listado exhaustivo de estados. Quizais non atopaches usos no código por eso. Pode ser?

Tenía usos en el puente que se eliminó, pero me suena bastante realista pensar que un integrador podría haberlo usado. Lo vuelvo a añadir como deprecado. Si consideras que no debería estar deprecado avísame y lo cambio sin problema.

situmops and others added 30 commits February 20, 2026 11:53

Automatic merge into master to Release 3.18.6

80500b4

Automatic merge into master to Release 3.18.6

Automatic merge into master to Release 3.18.7

f225669

Automatic merge into master to Release 3.18.7

Automatic merge into master to Release 3.18.8

ac5c4d2

Automatic merge into master to Release 3.18.8

Automatic merge into master to Release 3.18.9

d4bc9da

Automatic merge into master to Release 3.18.9

Automatic merge into master to Release 3.18.10

16c31d0

Automatic merge into master to Release 3.18.10

Automatic merge into master to Release 3.18.11

2be003f

Automatic merge into master to Release 3.18.11

Automatic merge into master to Release 3.18.12

857f3a6

Automatic merge into master to Release 3.18.12

Merge pull request #609 from situmtech/release/3.18.13

c6e5312

Automatic merge into master to Release 3.18.13

Automatic merge into master to Release 3.18.14

3411ec5

Automatic merge into master to Release 3.18.14

Automatic merge into master to Release 3.18.15

2a96744

Automatic merge into master to Release 3.18.15

Automatic merge into master to Release 3.18.16

2c0b5fe

Automatic merge into master to Release 3.18.16

Automatic merge into master to Release 3.18.17

8e89e32

Automatic merge into master to Release 3.18.17

Automatic merge into master to Release 3.18.18

aab7c2a

Automatic merge into master to Release 3.18.18

Automatic merge into master to Release 3.18.19

f246476

Automatic merge into master to Release 3.18.19

Automatic merge into master to Release 3.18.20

9e6a2e7

Automatic merge into master to Release 3.18.20

Automatic merge into master to Release 3.18.21

544777c

Automatic merge into master to Release 3.18.21

Automatic merge into master to Release 3.18.22

f3b291c

Automatic merge into master to Release 3.18.22

Automatic merge into master to Release 3.18.23

e039e40

Automatic merge into master to Release 3.18.23

Automatic merge into master to Release 3.18.24

6cf0c7b

Automatic merge into master to Release 3.18.24

Automatic merge into master to Release 3.18.25

bb9dfd1

Automatic merge into master to Release 3.18.25

Merge pull request #637 from situmtech/release/3.18.25

c1c6c03

Update version to 3.18.25

Automatic merge into master to Release 3.18.26

f5456f5

Automatic merge into master to Release 3.18.26

Merge pull request #642 from situmtech/release/3.18.26

6a6c501

Update version to 3.18.26

Added support for token authentication

b2c30cc

Updated react native version

f849990

Added native implementation for setToken

499e817

Fixed the auth being sent to the viewer when loading it with an apike…

22ec8b6

…y on the url

MapView now reloads when changing the apikey

fd61126

Cleaned some logic

0e18307

Added comments and cleaned old logic

ccab37f

adrian-situm commented Jul 20, 2026

View reviewed changes

Comment thread plugin/src/wayfinding/utils/mapper.ts

),

);

};

adrian-situm Jul 20, 2026

Copy link
Copy Markdown

Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se utilizaban exclusivamente en calculateRoute

adrian-situm commented Jul 20, 2026

View reviewed changes

Removed unused type

35456ba

adrian-situm commented Jul 20, 2026

View reviewed changes

Removed unused logic and updated some comments

2d316d3

adrian-situm commented Jul 20, 2026

View reviewed changes

adrian-situm added 2 commits July 20, 2026 15:21

Fixed a bug in MapView when selecting floors while navigation was run…

87b8ce0

…ning in the SDK

Fixed MapViewRef.deselectPoi not working

b8cd3d2

R-lagoman reviewed Jul 21, 2026

View reviewed changes

adrian-situm added 3 commits July 21, 2026 15:50

Small refactor in navigation callbacks and change in AccessibilityMod…

0d03415

…e documentation

Fixed removeNavigationUpdates never resolving when navigation was not…

ba12364

… running

Fixed navigationRunning desync when reaching destination

ad72f03

adrian-situm changed the title ~~Feature/prd 504 Removed routing bridge between MapView and native SDK~~ Feature/prd 504 Remove routing bridge between MapView and native SDK Jul 22, 2026

Updated changelog unreleased

2b86366

fsvilas reviewed Jul 22, 2026

View reviewed changes

Added some previously removed interfaces and marked them as deprecated

2a28fb7

R-lagoman approved these changes Jul 22, 2026

View reviewed changes

Added previously removed NavigationStatus as deprecated

70b83b1


		sendMessageToViewer(webViewRef.current, ViewerMapper.route(directions));
		}, [directions, mapLoaded]);


		### Removed

		- Removed routing and navigation bridge between MapView and native SDK.

Uh oh!

Conversation

adrian-situm commented Jul 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!