SK-2972: Implement get, update, delete, detokenize, tokenize for flowvault#270
Open
saileshwar-skyflow wants to merge 1 commit into
Conversation
…vault Adds the remaining vault operations for the FlowDB SDK variant, following insert's established controller/validator/data-class pattern, and extracts a shared non-empty-string-list check into common/utils/validations for flowvault and v2 to reuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get,update,delete,detokenize,tokenize— following the pattern already established forinsert(data classes, validators, controller methods, message catalog entries).validate_non_empty_string_listprimitive intocommon/utils/validationsand wires it into flowvault'sget/delete/tokenizevalidators;insert's success/error splitter is generalized (with an explicitinclude_dataopt-in) soget/updatecan reuse it without insert regressing.Stacked on #269 (SK-2954) — this PR's diff is only the new commit on top of that branch's tip.
Test plan
flowvault/tests/full suite passes (includes new get/update/delete/detokenize/tokenize + validation tests)common/tests/full suite passes (new shared validator + tests)v2/tests/full suite passes unchanged (confirms no regression from the shared validation extraction)