Add xcrs crate - #41
Open
setoelkahfi wants to merge 10 commits into
Open
Conversation
paydii
approved these changes
Jul 30, 2026
keypair34
approved these changes
Jul 30, 2026
smb_simulator_press_button, launch_app, terminate_app, and related tools required simulator_name/simulator_udid resolved via simctl, so they couldn't reach a ControlKit runner on a real iOS/tvOS device over the network. Add an optional host field (matching the pattern already used by smb_macos_click/smb_visionos_spatial_tap/smb_watchos_tap) and route app launch/terminate through the RPC methods instead of simctl when a host is given.
…port Simctl has no equivalent for a real device, so smb_simulator_screenshot couldn't capture one. Add a devicectl-backed Devicectl::screenshot next to Simctl::screenshot and expose it as smb_device_screenshot/ xcrs_device_screenshot. Also document the host field's physical-device usage across the ControlKit tool surface, which the previous commit added but left undocumented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A
Description
Type of Change
How Has This Been Tested?
cargo test --all-featuressmb <command>)Checklist
cargo check --workspacepassescargo clippy --workspace --tests -- -D warningspassescargo fmt --all -- --checkpassesunwrap()orexpect()calls in production codemod.rsfiles introducedCargo.tomland inherited with{ workspace = true }Release Notes