Skip to content

๐Ÿ’„ ์‹ค์‹œ๊ฐ„ ์ธ๊ธฐ ํŒŒ๊ฒฌํ•™๊ต ์นด๋“œ ์ด๋ฏธ์ง€ ํ•˜๋‹จ ๊ทธ๋ผ๋ฐ์ด์…˜ ์ถ”๊ฐ€#610

Open
manNomi wants to merge 3 commits into
mainfrom
fix/current-term-empty-universities
Open

๐Ÿ’„ ์‹ค์‹œ๊ฐ„ ์ธ๊ธฐ ํŒŒ๊ฒฌํ•™๊ต ์นด๋“œ ์ด๋ฏธ์ง€ ํ•˜๋‹จ ๊ทธ๋ผ๋ฐ์ด์…˜ ์ถ”๊ฐ€#610
manNomi wants to merge 3 commits into
mainfrom
fix/current-term-empty-universities

Conversation

@manNomi

@manNomi manNomi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Figma ๋…ธ๋“œ 4265:39768 (Rectangle 3416) ์—์„œ linear gradient ๊ฐ’์„ ์ถ”์ถœํ•˜์—ฌ PopularUniversityCard ๋Œ€ํ•™๊ต ์ด๋ฏธ์ง€ ํ•˜๋‹จ์— ๊ทธ๋ผ๋ฐ์ด์…˜ ์˜ค๋ฒ„๋ ˆ์ด ๋ฐ˜์˜

๋ณ€๊ฒฝ ๋‚ด์šฉ

apps/web/src/app/(home)/_ui/PopularUniversitySection/_ui/PopularUniversityCard.tsx

  • ์ด๋ฏธ์ง€ ์ปจํ…Œ์ด๋„ˆ ๋‚ด๋ถ€์— absolute inset-0 gradient overlay div ์ถ”๊ฐ€

Figma ๊ธฐ๋ฐ˜ ๊ทธ๋ผ๋ฐ์ด์…˜ ๊ฐ’ (๋…ธ๋“œ 4265:39770)

linear-gradient(
  to bottom,
  rgba(255, 255, 255, 0) 0%,
  rgba(0, 0, 0, 0.35) 75%,
  rgba(0, 0, 0, 0.70) 100%
)

Test plan

  • ํ™ˆ ํ™”๋ฉด > ์‹ค์‹œ๊ฐ„ ์ธ๊ธฐ ํŒŒ๊ฒฌํ•™๊ต ์นด๋“œ ์ด๋ฏธ์ง€ ํ•˜๋‹จ์— ๊ทธ๋ผ๋ฐ์ด์…˜์ด ์ž์—ฐ์Šค๋Ÿฝ๊ฒŒ ์ ์šฉ๋˜๋Š”์ง€ ํ™•์ธ
  • ๋Œ€ํ•™๊ต ์ด๋ฆ„ ํ…์ŠคํŠธ ๊ฐ€๋…์„ฑ ํ–ฅ์ƒ ํ™•์ธ
  • ๋ฐฐ๊ฒฝ ์ด๋ฏธ์ง€ placeholder ์ƒํƒœ์—์„œ๋„ ์ •์ƒ ํ‘œ์‹œ ํ™•์ธ

๐Ÿค– Generated with Claude Code

@manNomi
manNomi requested a review from wibaek as a code owner July 24, 2026 04:56
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview, Comment Jul 24, 2026 8:59am
solid-connect-web-admin Ready Ready Preview, Comment Jul 24, 2026 8:59am
solid-connection-web Ready Ready Preview, Comment Jul 24, 2026 8:59am

@github-actions github-actions Bot added the web label Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. ๐ŸŽ‰

โ„น๏ธ Recent review info
โš™๏ธ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bcc6d570-01d5-4de4-837f-f32773d21ce3

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between b2128f3 and 3063004.

โ›” Files ignored due to path filters (2)
  • docs/screenshots/gradient-after.png is excluded by !**/*.png
  • docs/screenshots/gradient-before.png is excluded by !**/*.png
๐Ÿ“’ Files selected for processing (1)
  • apps/web/src/app/(home)/_ui/PopularUniversitySection/_ui/PopularUniversityCard.tsx
๐Ÿšง Files skipped from review as they are similar to previous changes (1)
  • apps/web/src/app/(home)/_ui/PopularUniversitySection/_ui/PopularUniversityCard.tsx

Walkthrough

1. **๋ฐฐ๊ฒฝ ๊ทธ๋ผ๋””์–ธํŠธ ์˜ค๋ฒ„๋ ˆ์ด ์ถ”๊ฐ€**  
์ธ๊ธฐ ๋Œ€ํ•™ ์นด๋“œ์˜ ๋ฐฐ๊ฒฝ ์ด๋ฏธ์ง€ ํ•˜๋‹จ ์ ˆ๋ฐ˜์— ์ ˆ๋Œ€ ์œ„์น˜ ์„ ํ˜• ๊ทธ๋ผ๋””์–ธํŠธ ๋ ˆ์ด์–ด๋ฅผ ์ถ”๊ฐ€ํ•ด ์•„๋ž˜๋กœ ๊ฐˆ์ˆ˜๋ก ์–ด๋‘์›Œ์ง€๋„๋ก ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: wibaek

๐Ÿšฅ Pre-merge checks | โœ… 5
โœ… Passed checks (5 passed)
Check name Status Explanation
Title check โœ… Passed ์ œ๋ชฉ์ด PopularUniversityCard ์ด๋ฏธ์ง€ ํ•˜๋‹จ ๊ทธ๋ผ๋ฐ์ด์…˜ ์ถ”๊ฐ€๋ผ๋Š” ํ•ต์‹ฌ ๋ณ€๊ฒฝ์„ ๋ช…ํ™•ํžˆ ๋‹ด๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.
Description check โœ… Passed ์š”์•ฝ, ๋ณ€๊ฒฝ ๋‚ด์šฉ, ํ…Œ์ŠคํŠธ ๊ณ„ํš์ด ๊ฐ–์ถฐ์ ธ ์žˆ์–ด ๋Œ€์ฒด๋กœ ์™„์„ฑ๋„ ๋†’์ง€๋งŒ ๊ด€๋ จ ์ด์Šˆ์™€ ํŠน์ด ์‚ฌํ•ญ์€ ๋น„์–ด ์žˆ์Šต๋‹ˆ๋‹ค.
Docstring Coverage โœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check โœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check โœ… Passed Check skipped because no linked issues were found for this pull request.
โœจ Finishing Touches
๐Ÿ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/current-term-empty-universities

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

@manNomi

manNomi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

๐Ÿ“ธ Before / After

Before (๊ทธ๋ผ๋ฐ์ด์…˜ ์—†์Œ)

before

After (๊ทธ๋ผ๋ฐ์ด์…˜ ์ ์šฉ)

after


๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • inset-0 rounded-lg โ†’ bottom-0 inset-x-0 h-full rounded-b-lg (ํ•˜๋‹จ๋งŒ border-radius)
  • gradient ๋ฐฉํ–ฅ: to bottom โ†’ 180deg (Figma CSS ๊ทธ๋Œ€๋กœ ๋ฐ˜์˜)
  • gradient ๊ฐ’: linear-gradient(180deg, rgba(255, 255, 255, 0.00) 0%, rgba(0, 0, 0, 0.35) 75%, rgba(0, 0, 0, 0.70) 100%)

@manNomi

manNomi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

๐Ÿ“ธ Before / After (์ตœ์ข…)

Before

before

After (ํ•˜๋‹จ h-1/2 ์˜์—ญ์—๋งŒ ๊ทธ๋ผ๋ฐ์ด์…˜)

after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant