Add missing @sourceacademy/conductor devDependency to modules-buildtools - #854
Merged
Merged
Conversation
modules-buildtools/src/build/docs/__tests__/conductor.test.ts processes the real source of the repeat and rune bundles through TypeDoc to test doc normalization. Both bundles import types from @sourceacademy/conductor, but buildtools never declared it as a dependency of its own. This was invisible in a full workspace install (hoisting made it resolvable anyway) but breaks in the isolated `yarn workspaces focus` install CI uses for the modules-buildtools library job, where TypeDoc can't resolve the imported types and falls back to a bare 'default' export instead of discovering the repeat/twice/thrice and rune method members. @sourceacademy/modules-lib was also a candidate (rune also imports from it), but adding it creates a circular dependency since modules-lib already depends on modules-buildtools. @sourceacademy/conductor alone is enough to fix both failing tests.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the `@sourceacademy/modules-buildtools` library CI failure (both windows-latest and ubuntu-latest) from PR #680's run: https://github.com/source-academy/modules/actions/runs/30272720846
`lib/buildtools/src/build/docs/tests/conductor.test.ts` processes the real source of the `repeat` and `rune` bundles through TypeDoc to test doc normalization. Both bundles import types from `@sourceacademy/conductor`, but `modules-buildtools` never declared it as a dependency of its own.
This was invisible in a full workspace install (hoisting made it resolvable anyway), but breaks in the isolated `yarn workspaces focus` install CI uses for the `modules-buildtools` library job — TypeDoc can't resolve the imported types there and falls back to a bare `'default'` export instead of discovering the `repeat`/`twice`/`thrice` and rune method members:
`@sourceacademy/modules-lib` was also a candidate (rune also imports from it), but adding it creates a circular dependency since `modules-lib` already depends on `modules-buildtools`. `@sourceacademy/conductor` alone is enough to fix both failing tests.
This failure pattern predates PR #840 — it shows up on `conductor-migration` CI runs going back further (e.g. run 30242496974), so it's a pre-existing gap, not something introduced by the curve/plotly migration.
Verification
🤖 Generated with Claude Code