Skip to content

mig(skills): support skill version promotion - #4567

Merged
danielkov merged 1 commit into
mainfrom
dno-574-skill-version-promotion
Jul 28, 2026
Merged

mig(skills): support skill version promotion#4567
danielkov merged 1 commit into
mainfrom
dno-574-skill-version-promotion

Conversation

@danielkov

@danielkov danielkov commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an optional promotion timestamp for restoring an existing immutable skill version without duplicating canonical content
  • index effective version ordering for current-version resolution
  • index project and skill scoped feedback pagination

Summary by cubic

Add skill version promotion via optional promoted_at on skill_versions to restore an existing version without duplicating canonical content. Create concurrent indexes for effective ordering by COALESCE(promoted_at, created_at) and for project+skill feedback pagination (project_id, skill_id, created_at DESC, id DESC), and thread promoted_at through DB/repo models and query responses so current-following distributions observe restored content (DNO-574).

Written for commit 19b12c2. Summary will update on new commits.

Review in cubic

@danielkov
danielkov requested a review from a team as a code owner July 25, 2026 21:36
@linear-code

linear-code Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

DNO-574

@changeset-bot

changeset-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 19b12c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread server/database/schema.sql
Comment thread server/database/schema.sql
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from 8acd8e4 to bfa7950 Compare July 28, 2026 09:39
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from f2ae19c to e4cb4ec Compare July 28, 2026 09:39
@danielkov danielkov changed the title DNO-574: support skill version promotion mig(skills): support skill version promotion Jul 28, 2026
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from bfa7950 to 45ff60a Compare July 28, 2026 10:41
@danielkov
danielkov requested a review from a team as a code owner July 28, 2026 10:41
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from e4cb4ec to 6ff5556 Compare July 28, 2026 10:42
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from 45ff60a to e2ed847 Compare July 28, 2026 17:08
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from 6ff5556 to 1b39afd Compare July 28, 2026 17:08
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from e2ed847 to 331934d Compare July 28, 2026 17:26
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from 1b39afd to 28537f6 Compare July 28, 2026 17:26
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from 331934d to 99503db Compare July 28, 2026 18:16
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from 28537f6 to d1ca23f Compare July 28, 2026 18:17
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from 99503db to 2e3c199 Compare July 28, 2026 18:54
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from d1ca23f to 43ecbf4 Compare July 28, 2026 18:54
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from 2e3c199 to 3647162 Compare July 28, 2026 19:05
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from 43ecbf4 to c0f48da Compare July 28, 2026 19:05
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from 3647162 to f7b6ba3 Compare July 28, 2026 19:22
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from c0f48da to 67a8857 Compare July 28, 2026 19:23
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from f7b6ba3 to 57678fb Compare July 28, 2026 19:39
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from 67a8857 to 05152d2 Compare July 28, 2026 19:39
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from 57678fb to 9bd9f33 Compare July 28, 2026 19:52
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from 05152d2 to 0b04f99 Compare July 28, 2026 19:52
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from 9bd9f33 to e4392b3 Compare July 28, 2026 20:01
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from 0b04f99 to 900410e Compare July 28, 2026 20:01
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from e4392b3 to de070cc Compare July 28, 2026 20:28
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from 900410e to a4ec54d Compare July 28, 2026 20:28
@danielkov
danielkov force-pushed the dno-573-suggestion-management-api branch from de070cc to ab27586 Compare July 28, 2026 20:44
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from a4ec54d to 2f49eb7 Compare July 28, 2026 20:44
Base automatically changed from dno-573-suggestion-management-api to main July 28, 2026 21:01
@danielkov
danielkov force-pushed the dno-574-skill-version-promotion branch from 2f49eb7 to 19b12c2 Compare July 28, 2026 21:02
@github-actions

Copy link
Copy Markdown
Contributor

atlas migrate lint on server/migrations

Status Step Result
1 new migration file detected 20260728192302_dno_574_skill_version_promotion.sql
ERD and visual diff generated View Visualization
No issues found View Report
Read the full linting report on Atlas Cloud

@github-actions

Copy link
Copy Markdown
Contributor

atlas migrate lint on server/clickhouse/migrations

Status Step Result
No migration files detected  
ERD and visual diff generated View Visualization
No issues found View Report
Read the full linting report on Atlas Cloud

@danielkov
danielkov added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit d339a9c Jul 28, 2026
39 checks passed
@danielkov
danielkov deleted the dno-574-skill-version-promotion branch July 28, 2026 21:16
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants