Skip to content

[test]: validate a WorkBench data set without uploading - #8367

Merged
CarolineDenis merged 3 commits into
mainfrom
issue-8364
Jul 29, 2026
Merged

[test]: validate a WorkBench data set without uploading#8367
CarolineDenis merged 3 commits into
mainfrom
issue-8364

Conversation

@rijulpoudel

@rijulpoudel rijulpoudel commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Fixes #8364

Summary by CodeRabbit

  • Tests
    • Added coverage confirming dataset validation can complete without uploading data.
    • Verified validation produces expected results without creating upload state, upload records, or collection objects.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

Warning

One or more dependencies are approaching or past End-of-Life.
Please plan upgrades accordingly.

STATUS=WARNING
NODE_VERSION=20
NODE_CYCLE=20
EOL_DATE=2026-04-30
DAYS_REMAINING=-90

--- Node.js ---
Version: 20
EOL: 2026-04-30
Status: WARNING

STATUS=OK
PYTHON_VERSION=3.12
PYTHON_CYCLE=3.12
EOL_DATE=2028-10-31
DAYS_REMAINING=825

--- Python ---
Version: 3.12
EOL: 2028-10-31
Status: OK

STATUS=WARNING
DJANGO_VERSION=4.2
DJANGO_CYCLE=4.2
EOL_DATE=2026-04-07
DAYS_REMAINING=-113

--- Django ---
Version: 4.2
EOL: 2026-04-07
Status: WARNING


@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a55d9c9-369c-49c4-8ccb-a4bbd0ad94a1

📥 Commits

Reviewing files that changed from the base of the PR and between b2423fd and f4ff7c5.

📒 Files selected for processing (1)
  • specifyweb/backend/workbench/tests.py

📝 Walkthrough

Walkthrough

Adds a WorkBench test that validates a configured dataset without uploading it, checking validation results and confirming no uploader state or collection object is created.

Changes

Workbench validation

Layer / File(s) Summary
Dataset validation without upload
specifyweb/backend/workbench/tests.py
Adds model imports and tests successful validation, absent uploader state and upload result, one non-failing row result, and no matching Collectionobject.

Possibly related PRs

  • specify/specify7#8342: Adds related DataSetTests covering WorkBench dataset validation and stored import state.

Suggested reviewers: carolinedenis

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: validating a WorkBench dataset without uploading it.
Linked Issues check ✅ Passed The added test directly matches issue #8364 by validating a WorkBench dataset without uploading it.
Out of Scope Changes check ✅ Passed The changes stay within scope by adding a focused test and related imports only.
Automatic Tests ✅ Passed PR adds an automated test test_validate_dataset_without_uploading in specifyweb/backend/workbench/tests.py, covering validation without upload and no record creation.
Testing Instructions ✅ Passed The new test clearly exercises /api/workbench/validate/{id}/ and verifies no upload side effects, matching the affected WorkBench validation path.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8364

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CarolineDenis
CarolineDenis merged commit 01f1a2d into main Jul 29, 2026
20 checks passed
@CarolineDenis
CarolineDenis deleted the issue-8364 branch July 29, 2026 07:21
@github-project-automation github-project-automation Bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

[test]: Validate a WorkBench data set without uploading it

2 participants