Fix: EU region URL change for NinjaOne plugin#77
Open
Deenk wants to merge 2 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated NinjaOne regional API base URL hostnames in ChangesNinjaOne endpoint and version update
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
clarkd
reviewed
Jul 1, 2026
Switches US/US2/CA/OC to the documented app./us2./ca./oc.ninjarmm.com hostnames instead of the api./-api variants, matching the same fix already applied to EU to avoid the same class of region-URL issue. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🧩 Plugin PR Summary📦 Modified Plugins
📋 Results
🔍 Validation Details✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Quite a simple region change for the EU region for the NinjaOne plugin. This does not break existing EU region customers as the new/changed URL resolves to the same API. This change is needed though as some NinjaOne customers do require eu.ninjarmm.com. The existing eu-api.ninjarmm.com URL that the plugin uses is an alias that seemingly not all customers can use.
🔗 Related issue(s)
https://squaredup-eng.atlassian.net/browse/PLUG-4662
🧩 Plugin details
Does this PR introduce any breaking changes?
If yes, describe:
📚 Documentation
✅ Checklist
Summary by CodeRabbit