Skip to content

Fix: EU region URL change for NinjaOne plugin#77

Open
Deenk wants to merge 2 commits into
mainfrom
fix-ninjaone-eu-region
Open

Fix: EU region URL change for NinjaOne plugin#77
Deenk wants to merge 2 commits into
mainfrom
fix-ninjaone-eu-region

Conversation

@Deenk

@Deenk Deenk commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

Quite a simple region change for the EU region for the NinjaOne plugin. This does not break existing EU region customers as the new/changed URL resolves to the same API. This change is needed though as some NinjaOne customers do require eu.ninjarmm.com. The existing eu-api.ninjarmm.com URL that the plugin uses is an alias that seemingly not all customers can use.


🔗 Related issue(s)

https://squaredup-eng.atlassian.net/browse/PLUG-4662


🧩 Plugin details

  • Plugin name:
  • Type of change:
    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe):

⚠️ Breaking changes

Does this PR introduce any breaking changes?

  • No
  • Yes (please describe):

If yes, describe:

  • What breaks
  • Who is impacted
  • Any migration steps

📚 Documentation

  • Documentation updated
  • No documentation changes needed

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

Summary by CodeRabbit

  • Bug Fixes
    • Updated the NinjaOne API base URL settings to use the latest endpoint hostnames (including Canada and EU), ensuring requests go to the correct regional services.
  • Chores
    • Bumped the NinjaOne plugin version to 1.1.14.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5850d391-96d5-4b20-ba39-cef4456fd50c

📥 Commits

Reviewing files that changed from the base of the PR and between 3717b12 and 9545570.

📒 Files selected for processing (2)
  • plugins/NinjaOne/v1/metadata.json
  • plugins/NinjaOne/v1/ui.json

📝 Walkthrough

Walkthrough

Updated NinjaOne regional API base URL hostnames in ui.json and incremented the plugin version from 1.1.12 to 1.1.14 in metadata.json.

Changes

NinjaOne endpoint and version update

Layer / File(s) Summary
Endpoint configuration and version update
plugins/NinjaOne/v1/ui.json, plugins/NinjaOne/v1/metadata.json
Regional apiBaseUrl option values and the default hostname are updated while labels remain unchanged; the plugin version is incremented to 1.1.14.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main change: NinjaOne region URL updates, especially the EU endpoint change.
Description check ✅ Passed The description is mostly complete and matches the template with summary, issue link, change type, breaking changes, docs, and checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Deenk Deenk marked this pull request as ready for review July 1, 2026 09:36
@Deenk Deenk requested a review from a team July 1, 2026 09:36
@Deenk Deenk changed the title fix eu region for customer Fix: EU region URL change for NinjaOne plugin Jul 1, 2026
Comment thread plugins/NinjaOne/v1/ui.json
Switches US/US2/CA/OC to the documented app./us2./ca./oc.ninjarmm.com
hostnames instead of the api./-api variants, matching the same fix
already applied to EU to avoid the same class of region-URL issue.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/NinjaOne/v1

📋 Results

Step Status
Validation ✅ Passed
Deployment 🚀 Deployed

🔍 Validation Details

ninja-one
{
  "valid": true,
  "pluginName": "ninja-one",
  "pluginType": "cloud",
  "summary": {
    "Data Streams": 37,
    "Import Definitions": 1,
    "UI Configuration": true,
    "Has Icon": true,
    "Has Default Content": true,
    "Config Validation": true,
    "Custom Types": true
  }
}

@Deenk Deenk requested a review from clarkd July 14, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants