fix(tools): HTTP timeouts + bound SBOM-browser concurrency#150
Open
lfrancke wants to merge 1 commit into
Open
Conversation
- nexus-garbage-collector, monitor-oci-artifacts: give the reqwest client a 30s timeout so a hung/slow registry can't block the job forever (monitor now reuses one shared client instead of bare reqwest::get calls). - harbor-sbom-browser: give its client a 30s timeout, and cap the artifact tree build at 8 concurrent repository request-chains (buffer_unordered) instead of firing one per sdp/ repository at once on every cache miss. (The harbor-garbage-collector already got its shared timeout client in its own safety PR.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust tool robustness (F22, F23)
nexus-garbage-collector,monitor-oci-artifactsandharbor-sbom-browserused clients/reqwest::getwith no timeout, so a hung/slow registry blocked the process indefinitely. All now use a client with a 30s timeout (monitor-ocialso switches from barereqwest::getto one shared client).harbor-sbom-browser'sbuild_artifact_treefired one request-chain persdp/repository at once viatry_join_allon every cache miss. Now capped at 8 concurrent viabuffer_unordered.harbor-garbage-collectorgot its shared timeout client in its own safety PR (#149).Verification
cargo check+cargo clippyclean on all three. (The one remaining clippy note — unusedmanifest_media_type/media_typefields inmonitor-oci— is pre-existing and untouched here.)Container/build hardening (cosign checksum, base-image digest pinning, Jenkins secret handling) follows in a separate PR.