ROX-34386: Backport changes from release branch - #171
Conversation
📝 WalkthroughWalkthroughChangesThe Tekton manifests separate main and release triggers, add CPE labels, and configure release builds. The component pipeline derives Git-based versions for image and Coverity tasks. The Dockerfile adds versioned runtime image metadata. Konflux versioned builds
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant GitEvent
participant PipelineAsCode
participant PipelineRun
participant basic-component-pipeline
participant determine-version
participant buildah-remote-oci-ta
GitEvent->>PipelineAsCode: push or pull_request event
PipelineAsCode->>PipelineRun: select main or release trigger
PipelineRun->>basic-component-pipeline: start configured pipeline
basic-component-pipeline->>determine-version: provide cloned source
determine-version->>determine-version: run git describe --tags --always
determine-version->>buildah-remote-oci-ta: provide VERSION and combined LABELS
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/acs-mcp-server-pull-request.yaml:
- Around line 57-60: Remove the placeholder extra-labels block from
.tekton/acs-mcp-server-pull-request.yaml lines 57-60,
.tekton/acs-mcp-server-push-main.yaml lines 68-71, and
.tekton/acs-mcp-server-push-release.yaml lines 66-69 so no pipeline publishes
the literal X.Y CPE version.
In @.tekton/basic-component-pipeline.yaml:
- Around line 200-205: Add a suitable limits.cpu value under
computeResources.limits in the shared stepTemplate for the new task steps,
alongside the existing memory limit, so both containers receive CPU limits while
preserving the current CPU request.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 86d619d4-8f80-42d5-a90e-ec0c06a95890
📒 Files selected for processing (5)
.tekton/acs-mcp-server-pull-request.yaml.tekton/acs-mcp-server-push-main.yaml.tekton/acs-mcp-server-push-release.yaml.tekton/basic-component-pipeline.yamlkonflux.Dockerfile
E2E Test ResultsCommit: 6f566b1 |
❌ 2 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
6818169 to
67654a9
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/acs-mcp-server-push-main.yaml:
- Around line 21-27: Remove the pull_request trigger branch from the push
trigger conditions in .tekton/acs-mcp-server-push-main.yaml lines 21-27,
retaining only the main push trigger. Apply the same change in
.tekton/acs-mcp-server-push-release.yaml lines 21-27, retaining the release and
tag push triggers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: f66be5cf-29f6-438b-844a-26d5efe2ac34
📒 Files selected for processing (5)
.tekton/acs-mcp-server-pull-request.yaml.tekton/acs-mcp-server-push-main.yaml.tekton/acs-mcp-server-push-release.yaml.tekton/basic-component-pipeline.yamlkonflux.Dockerfile
67654a9 to
6f566b1
Compare
Description
This PR backports changes done in release branch.
Note for reviewer
Validation