Conversation
SWWebView.onCreateInputConnection unconditionally replaced Chromium's InputConnection with a dummy BaseInputConnection(this, false). A dummy connection can't deliver committed/composing text to web content, so committed text falls back to synthetic key events via KeyCharacterMap, which only maps ASCII — silently dropping Cyrillic, Thai, Korean, emoji and swipe/gesture typing in any paywall input since 1.0. Gate the dummy connection on isGameControllerEnabled, mirroring the sibling dispatchKeyEvent/dispatchGenericMotionEvent overrides, and delegate to the WebView otherwise (also before Superwall is configured). Game controllers deliver hardware KeyEvents through dispatchKeyEvent and never go through the InputConnection, so controller capture keeps working unchanged. Fixes SW-5645 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Run against the project-default Robolectric SDK level per review. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…all-inputs-silently-drop-all-non-latin Fix paywall inputs silently dropping all non-Latin keyboard text
… the app A fire-and-forget action that throws (e.g. CheckWebEntitlements failing with BillingError.BillingNotAvailable when Play Billing returns NETWORK_ERROR) previously escaped the consumer loop into the actor's scope. The default scope is a plain CoroutineScope(Dispatchers.IO) with no CoroutineExceptionHandler, so the exception killed the process; it also terminated the FIFO consumer, silently dropping all subsequent actions for the session. Wrap each unit of work in withErrorTracking, matching the behavior of the SuperwallScope exception handlers. immediate() callers still receive exceptions via the existing CompletableDeferred path.
- Pass -PmavenCentralAutomaticPublishing=true to the publish tasks so the Central Portal deployment is released automatically instead of waiting for a manual 'Publish' click. - Extract the released version's section from CHANGELOG.md and create the GitHub release automatically with it as the description, replacing the Slack message asking someone to create the release by hand. - Create the release with a PAT (falling back to GITHUB_TOKEN) so the release event still triggers on-release.yml's paywall-next dispatch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MHtJcvAKTQPjshrN6pMidJ
…ht-exceptions Guard SequentialActor consumer loop so a throwing action cannot crash the app
…ion-6xajox Automate GitHub release creation and Maven Central publishing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.7.23
Fixes
InputConnectionwith a dummy one unlessisGameControllerEnabledis set, restoring the full IME pipeline (composition, autocorrect, swipe typing, autofill) for everyone else.