chore: bump SwapKit dependencies + fix auto-update lockfile convergence#114
Merged
Conversation
…ence Bump to the latest SDK patch train (core 4.6.1, helpers 4.19.1, plugins 4.7.1, server 4.4.2, toolboxes 4.26.1, wallet-core 4.3.19, wallet-keystore 4.5.2). Also fix the auto-update-core workflow's TS2883 dts failure: a plain bun install keeps stale lockfile resolutions for @swapkit consumers not in the dispatch payload (wallet-core kept helpers@4.19.0 next to the bumped 4.19.1), so tsc declaration emit sees two AddChainType symbols and cannot name the transitive one portably. The install step now runs bun update across the whole external @swapkit family (manifests saved and restored around it) so the lockfile converges on one copy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps external
@swapkit/*dependencies to the latest SDK patch train and fixes the TS2883build:dtsfailure that killed the latestauto-update-corerun.Root cause of the TS2883 dts failure
The auto-bump edits manifests only for packages in the dispatch payload, and a plain
bun installkeeps stale lockfile resolutions for@swapkitconsumers that weren't republished in the same train. In the failing run,wallet-corestill resolvedhelpers@4.19.0while the workspace's direct dep moved to4.19.1— with the isolated linker that means two copies of helpers in the store, socreateWallet's inferred type references anAddChainTypesymbol that has no portable import path →TS2883onkeepkeyWallet/ledgerWallet/trezorWallet.Reproduced locally byte-for-byte (develop lockfile + partial bump), then verified the fix on that exact state.
Workflow fix
The install step now converges the whole external
@swapkit/*family viabun update(family derived from the manifests, workspace packages excluded). Sincebun updatealso rewrites manifests (exact-pins root deps, adds named deps missing from root), they're saved and restored around it, followed by a normalbun install(which runs sherif as postinstall to validate).Includes the changeset from
generate:dep-changeset(patch bump for all 5 workspace packages) so merging triggers the Version Packages release PR.Verification: sherif ✓,
bun run build✓,build:dts✓ (previously failing),type-check✓ (all 5 packages),bun test43/43 ✓.🤖 Generated with Claude Code