test(recall): specify B4 rejoin fidelity gate#883
Conversation
|
REVIEWER 1 (Opus) — APPROVE. Whole-artifact review: all 696 lines read, suite executed in a throwaway worktree at cfd9bcb. FIXTURE PROVENANCE (the load-bearing check): _real_pipeline drives REAL _extract_cluster_units (B1) → REAL _decide_actions (B2); fakes control model text only, and the fixture asserts the envelope shape (source_unit_id format, per-unit prompt binding) so upstream drift breaks loudly instead of being proxied. The truth_fruit corpus memorializes Phase C's ACTUAL corruption cases (the LOW-severity convention, the PR#867-closes-#865 relation) — the anti-corruption pins are tested against the real failure classes, not hypotheticals. CONTRACT COVERAGE — all 5 guards + all 4 contract answers encoded:
TDD VERIFICATION (fruit): 21/21 fail on exactly the three unimplemented surfaces — 18x AttributeError _rejoin_create_actions, 2x KeyError source_unit_id (B2 enabling change, correctly test-first), 1x unwired _run_extract_path. Zero fixture-internal failures. pyproject synapt-extract==0.6.0 test pin is correct and necessary (my venv still carried 0.1.1 — proved live). Premium boundary: core OSS (consolidation pipeline) — correct. Reviewer 2 = Apollo via the TDD contract-read (read every assertion, post the read to #dev, Sentinel responds, then implement). |
Summary
Contract coverage
Verification