Skip to content

fix: increase streaming chunk size for CSV and Excel view downloads #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacalata wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: increase streaming chunk size for CSV and Excel view downloads #1817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tableauserverclient/server/endpoint/views_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import logging
from contextlib import closing

from tableauserverclient.config import BYTES_PER_MB, config

from tableauserverclient.models.permissions_item import PermissionsRule
from tableauserverclient.server.endpoint.endpoint import QuerysetEndpoint, api
from tableauserverclient.server.endpoint.exceptions import MissingRequiredFieldError, UnsupportedAttributeError
Expand Down Expand Up @@ -264,7 +266,7 @@ def _get_view_csv(self, view_item: ViewItem, req_options: "CSVRequestOptions | N
url = f"{self.baseurl}/{view_item.id}/data"

with closing(self.get_request(url, request_object=req_options, parameters={"stream": True})) as server_response:
yield from server_response.iter_content(1024)
yield from server_response.iter_content(config.CHUNK_SIZE_MB * BYTES_PER_MB)

@api(version="3.8")
def populate_excel(self, view_item: ViewItem, req_options: "ExcelRequestOptions | None" = None) -> None:
Expand Down Expand Up @@ -303,7 +305,7 @@ def _get_view_excel(self, view_item: ViewItem, req_options: "ExcelRequestOptions
url = f"{self.baseurl}/{view_item.id}/crosstab/excel"

with closing(self.get_request(url, request_object=req_options, parameters={"stream": True})) as server_response:
yield from server_response.iter_content(1024)
yield from server_response.iter_content(config.CHUNK_SIZE_MB * BYTES_PER_MB)

@api(version="3.2")
def populate_permissions(self, item: ViewItem) -> None:
Expand Down
Loading