fix(patches): link WPROGRAM with MAINLIBS in the msys pass-1 GNUmakefile#39
Merged
Merged
Conversation
The windows runtime legs (libtfs v0.13.0 x v0.2.4 patches) link rubyw.exe with '-Wl,--start-group $(LIBS) -Wl,--end-group' and fail with undefined tebako_fs_* / tebako_mount_point references from the io-shimmed objects (dir.o & co). In the gem's two-pass flow the toolchain tree carried no io shims at pass-1 time, so LIBS sufficed; the pre-patched pass-1 tree has the shims from the start, and the pass-2 variant of the same rule already links MAINLIBS. Make the pass-1 rule match it (7 files, all lines; the consumer substitutes MAINLIBS into config.status before the toolchain build). Verified: tools/apply --platform msys --pass 1 for 3.1.6/3.1.7/ 3.2.4/3.2.7/3.3.3/3.3.7/3.4.2/4.0.6 -- every tree's WPROGRAM rule carries --start-group $(MAINLIBS); tools/lint 3.3.7 + 4.0.6 clean.
ronaldtse
added a commit
to tamatebako/tebako-runtime-ruby
that referenced
this pull request
Jul 25, 2026
v0.2.5 carries the pass-1 WPROGRAM MAINLIBS link fix (tamatebako/ruby#39) on top of the v0.2.4 F_GETFL guard (tamatebako/ruby#38): the windows legs' rubyw.exe link now gets the tebako library set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows runtime legs (libtfs v0.13.0 x v0.2.4 patches) link rubyw.exe with '-Wl,--start-group $(LIBS) -Wl,--end-group' and fail with undefined tebako_fs_* / tebako_mount_point references from the io-shimmed objects (dir.o & co). In the gem's two-pass flow the toolchain tree carried no io shims at pass-1 time, so LIBS sufficed; the pre-patched pass-1 tree has the shims from the start, and the pass-2 variant of the same rule already links MAINLIBS. Make the pass-1 rule match it (7 files, all lines; the consumer substitutes MAINLIBS into config.status before the toolchain build).
Verified: tools/apply --platform msys --pass 1 for 3.1.6/3.1.7/3.2.4/3.2.7/3.3.3/3.3.7/3.4.2/4.0.6 -- every tree's WPROGRAM rule carries --start-group $(MAINLIBS); tools/lint 3.3.7 + 4.0.6 clean.
Next step after merge: tag v0.2.5 so tebako-runtime-ruby's windows legs consume the fixed scenario.