Close the drift loop: hunk output in failure issues, pin-bump dispatch on release-src publish#41
Merged
Merged
Conversation
- Onboarder::Result gains 'failures' (patch name -> git apply output), so the monitor's failure issue carries the failing hunk output, not just patch names; spec asserts it (fixture patch made well-formed so it produces a real context-mismatch failure). - release-src publish records the published tag in a 'release-tag' artifact, readable for both trigger paths (tag push, manual dispatch). - New runtime-pin-bump.yml: on workflow_run(release-src, success), read the tag back and fire a repository_dispatch (event 'tfs-ruby-src-release', TEBAKO_CI_PAT_TOKEN -- the same cross-repo mechanism release-monitor already uses) to tebako-runtime-ruby, which opens a DEFAULT_RELEASE pin-bump PR. Idempotent: the runtime side no-ops on a repeated tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap item 17 — no human touches the ruby-new-release drift loop.
The loop
Onboarder::Resultnow exposesfailures(patch name → git apply output), so the auto-filed issue contains the failing hunk output, not just patch names. Re-running with no new release still does nothing (empty detect matrix).release-tagartifact (works for both trigger paths: tag push and manual dispatch, where the tag otherwise isn't recoverable from the workflow_run payload).workflow_run(release-src, conclusion: success)it reads the tag back from that artifact and fires arepository_dispatch(eventtfs-ruby-src-release, payloadtag) to tamatebako/tebako-runtime-ruby using theTEBAKO_CI_PAT_TOKENsecret — the samegh api .../dispatchescross-repo mechanism release-monitor already uses; no new secrets. The runtime repo (companion PR) opens aDEFAULT_RELEASEpin-bump PR on abot/source-pin-<tag>branch; its CI matrix runs on the PR; nothing auto-merges.Idempotent: a re-dispatched tag no-ops downstream (pin already there or branch exists). No force-pushes anywhere.
Testing
bundle exec rspec: 61 examples, 0 failures (onboarder spec now asserts the hunk output; the bogus-patch fixture was made well-formed so it fails as a real context mismatch, not 'corrupt patch').actionlint: new/changed files clean (two pre-existing shellcheck infos in untouched steps remain).gh api repos/tamatebako/tebako-runtime-ruby/dispatches -f event_type=tfs-ruby-src-release -F 'client_payload[tag]=<tag>'is the fallback.