fix 'Refresh failed: Invalid token provided' caused by token-fresher request to wrong idc - #118
Open
CavemanIV wants to merge 1 commit into
Open
Conversation
…request to wrong idc if serviceRegion is not same with ARN region
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User may experience frequently error if they use non US access point.
An IdC account has two regions and they are not always the same: the OIDC
region that issued the SSO session and refresh token, and the service
region where the CodeWhisperer profile lives. The sync layer set both to
the profile ARN's region, discarding the real OIDC region:
Since token.ts resolves
auth.oidcRegion || auth.regionto build therefresh URL, every refresh for such an account went to the wrong endpoint
and failed deterministically.
Confirmed by probing both endpoints with the account's real credentials:
POST oidc.ap-southeast-1.amazonaws.com/token -> 200, expiresIn 3600
POST oidc.us-east-1.amazonaws.com/token
-> 400 invalid_request / "Invalid token provided"
The observed case is an ap-southeast-1 session paired with a us-east-1
profile ARN. The DB schema already had separate region/oidc_region
columns and token.ts already preferred oidcRegion, so only the sync layer
needed fixing.