fix(app): strip trailing slash from custom vendor website URLs (CS-398)#3500
Open
github-actions[bot] wants to merge 3 commits into
Open
fix(app): strip trailing slash from custom vendor website URLs (CS-398)#3500github-actions[bot] wants to merge 3 commits into
github-actions[bot] wants to merge 3 commits into
Conversation
chasprowebdev
changed the title
chasprowebdev
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge chas/custom-vendor-url-format into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Standardizes custom vendor website input by trimming and cleaning domains (strip protocol, www, and trailing slashes) and validating the cleaned value. Fixes false “invalid URL” states and ensures consistent display and saving. Addresses CS-398.
cleanDomainInputthat trims and removes protocol,www, and trailing slashes; used for display, change handlers, and touched-invalid checks.isValidDomainto validate the cleaned value; allows empty, rejects paths/spaces, requires a dot; accepts inputs with protocol/www/slash by cleaning first.https://to cleaned values for storage; added unit tests covering trimming, protocols,www, trailing slashes, and valid/invalid cases.Written for commit 77d6177. Summary will update on new commits.