Skip to content

fix: prevent standalone net labels from intersecting traces - #750

Merged
techmannih merged 2 commits into
mainfrom
fux2
Jul 31, 2026
Merged

fix: prevent standalone net labels from intersecting traces#750
techmannih merged 2 commits into
mainfrom
fux2

Conversation

@techmannih

@techmannih techmannih commented Jul 31, 2026

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 31, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel

vercel Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
schematic-trace-solver Ready Ready Preview Jul 31, 2026 10:46am

Request Review

MustafaMulla29
MustafaMulla29 reviewed Jul 31, 2026
View reviewed changes
Comment thread ...s/bug-reports/bug-report-20260731T052229Z/__snapshots__/bug-report-20260731T052229Z.snap.svg

@MustafaMulla29 MustafaMulla29 Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesnt the trace to that label look wierd?

Screenshot 2026-07-31 at 3 32 55 PM

cant we just push the below label, then it will have a straight trace.

@techmannih
techmannih merged commit b51a346 into main Jul 31, 2026
5 checks passed
@techmannih
techmannih deleted the fux2 branch July 31, 2026 11:15
mohan-bee
mohan-bee reviewed Jul 31, 2026
View reviewed changes

@mohan-bee mohan-bee left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MustafaMulla29 @techmannih that netlabel is bad ... They were not aligned properly still ... !!

@MustafaMulla29

MustafaMulla29 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@MustafaMulla29 @techmannih that netlabel is bad ... They were not aligned properly still ... !!

This is a follow up improvement, the current output is acceptable

@tscircuitbot

tscircuitbot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohan-bee mohan-bee mohan-bee left review comments
@MustafaMulla29 MustafaMulla29 MustafaMulla29 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@techmannih @MustafaMulla29 @tscircuitbot @mohan-bee