[pull] master from php:master#1093
Merged
Merged
Conversation
…#22746) Now that arguments in warnings can be configured to always appear it is no longer necessary to use `php_error_docref2()`.
As arguments to functions are now handled globally via an INI setting.
Fix EXIF warning format specifiers for size_t values Several EXIF warning messages printed `size_t` values using `%d` or `%X`, which does not match the argument type passed through varargs. Use `%zu` / `%zX` for size and offset values to avoid undefined behavior and make the diagnostics portable across platforms. No behavior change is intended apart from the corrected warning formatting.
…am functions (#22749) Since all warnings can now display the arguments of the call, the stream layer can just piggyback on-top of it instead of the additional complexity of handling it. This is only a first step as there is still the 1 param variant that needs to be converted.
gh20620 and bzdecompress_input_too_large each allocate ~4GB under RUN_RESOURCE_HEAVY_TESTS; two in parallel exhaust a memory-constrained runner and the OOM killer aborts the whole run. Mark both --CONFLICTS-- all so run-tests executes them in isolation, matching ext/tidy/tests/parsing_file_too_large.phpt.
* PHP-8.2: Fix leak on double DatePeriod::__construct() call
* PHP-8.3: Fix leak on double DatePeriod::__construct() call
* PHP-8.4: Fix leak on double DatePeriod::__construct() call
* PHP-8.5: Fix leak on double DatePeriod::__construct() call
SQLBindParameter recorded deferred pointers (P->outbuf, &P->len, and the bound-parameter struct) into the ODBC statement at PDO_PARAM_EVT_ALLOC, and P->outbuf was never freed. Both outlive the bound-parameter struct, which PDO destroys mid-statement on execute() with an array or a rebind: the buffer leaked and the stale binding made the next SQLExecute read freed memory. Track output buffers on the statement and free them in the destructor, and defer binding to execute time, resetting and rebinding the current parameters when the set changed. Closes GH-22735
* PHP-8.4: Fix pdo_odbc output-buffer leak and stale-binding out-of-bounds read
* PHP-8.5: Fix pdo_odbc output-buffer leak and stale-binding out-of-bounds read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )