chore: textlint-rule-preset-ja-technical-writingを追加#412
Open
3w36zj6 wants to merge 24 commits into
Open
Conversation
3w36zj6
marked this pull request as ready for review
July 17, 2026 17:54
3w36zj6
requested review from
gomazarashi,
kimushun1101 and
ultimatile
as code owners
July 17, 2026 17:54
Member
|
個人的な感覚でひとまずコメントしてみました。採否はお任せいたします。 |
ultimatile
reviewed
Jul 18, 2026
ultimatile
reviewed
Jul 18, 2026
Co-authored-by: ultimatile <18307308+ultimatile@users.noreply.github.com>
Co-authored-by: 3w36zj6 <52315048+3w36zj6@users.noreply.github.com>
Co-authored-by: 3w36zj6 <52315048+3w36zj6@users.noreply.github.com>
Co-authored-by: 3w36zj6 <52315048+3w36zj6@users.noreply.github.com>
Co-authored-by: kimushun1101 <13430937+kimushun1101@users.noreply.github.com>
Co-authored-by: 3w36zj6 <52315048+3w36zj6@users.noreply.github.com>
Co-authored-by: 3w36zj6 <52315048+3w36zj6@users.noreply.github.com>
Co-authored-by: 3w36zj6 <52315048+3w36zj6@users.noreply.github.com>
Co-authored-by: 3w36zj6 <52315048+3w36zj6@users.noreply.github.com>
ultimatile
reviewed
Jul 19, 2026
| /// ``` | ||
| /// | ||
| /// `layout`が提供する幅と高さは、対象ページの寸法が`{auto}`に設定されていると無限大になりうることに注意してください。 | ||
| /// `layout`が提供する幅と高さは、対象ページの寸法が`{auto}`に設定されていると無限大となりうることに注意してください。 |
Contributor
There was a problem hiding this comment.
これに〜に〜に反応しているっぽいですが、修正後はと〜と〜になっているように見えるのですが、それはいいんですかね？
Member
Author
There was a problem hiding this comment.
no-doubled-joshiは助詞の表記だけでなく、kuromojiによる品詞細分類も含めて比較しています。
修正前は「無限大に」の「に」と「なりうることに」の「に」がどちらも格助詞として連続するため違反となりますが、修正後の「設定されていると」の「と」は接続助詞、「無限大となりうる」の「と」は格助詞として解析されるため、同じ助詞の連続とは判定されません。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #372
変更点
gpt-5.5)で修正した