Skip to content

Fix internal boundary integral MPI test deform API#332

Closed
ss2098 wants to merge 1 commit into
underworldcode:developmentfrom
ss2098:ss2098/fix-internal-boundary-deform-api-test
Closed

Fix internal boundary integral MPI test deform API#332
ss2098 wants to merge 1 commit into
underworldcode:developmentfrom
ss2098:ss2098/fix-internal-boundary-deform-api-test

Conversation

@ss2098

@ss2098 ss2098 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This PR updates tests/parallel/test_0765_internal_boundary_integral_mpi.py so the deformed spherical-shell boundary-area MPI test uses the public mesh.deform() API instead of calling the internal Mesh._deform_mesh() method directly.

The previous test path is rejected by the coordinate-mutation capability guard on current development. This keeps the test aligned with the public mesh-deformation API without changing the purpose of the regression test.

Validation:

  • pixi run mpirun -np 2 python -m pytest -q --with-mpi tests/parallel/test_0765_internal_boundary_integral_mpi.py::test_deformed_spherical_shell_boundary_area_parallel
  • pixi run mpirun -np 4 python -m pytest -q --with-mpi tests/parallel/test_0765_internal_boundary_integral_mpi.py::test_deformed_spherical_shell_boundary_area_parallel
  • pixi run mpirun -np 2 python -m pytest -q --with-mpi tests/parallel/test_0765_internal_boundary_integral_mpi.py
  • pixi run mpirun -np 4 python -m pytest -q --with-mpi tests/parallel/test_0765_internal_boundary_integral_mpi.py

@lmoresi

lmoresi commented Jul 23, 2026

Copy link
Copy Markdown
Member

Triage note (2026-07-23): this one-line fix (_deform_meshdeform in test_0765) landed on development via PR #396 (merged today, with issue #331 closed), so this PR is superseded — the change it proposes is already in. Thanks @ss2098 for spotting it early; recommending the maintainers close this one.

Underworld development team with AI support from Claude Code

@lmoresi

lmoresi commented Jul 23, 2026

Copy link
Copy Markdown
Member

Closing as superseded — the identical fix landed via PR #396 (see comment above).

@lmoresi lmoresi closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants