Swarm-notification version bump belongs in deform(), not the internal primitive#388
Merged
Merged
Conversation
…he internal primitive Composing the #379 stack on development surfaced a consumer the per-branch gates could not see: the snapshot system treats _mesh_version as its integrity key, and the #382 bump inside _deform_mesh also fired on the snapshot RESTORE path — recovery then refused its own snapshot (test_0007). The bump moves to the public deform(), which is what users call and what strands swarms; internal primitive callers (snapshot restore, remesh transactions, movers) no longer perturb the version. The coords-callback path keeps its own bump for direct mesh.X.coords writes. Gate: 435 passed (test_0007 green again); swarm deform-notification regression test still passes through the public path. Underworld development team with AI support from Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up defect from composing the #379 stack (#381-#385) on development — a consumer the per-branch gates could not see: the snapshot system treats
_mesh_versionas its integrity key, and the #382 bump inside_deform_meshalso fired on the snapshot RESTORE path, so recovery refused its own snapshot (test_0007_snapshot_inmemory).The bump moves to the public
deform()— what users call, and the path that strands swarms — so internal primitive callers (snapshot restore, remesh transactions, movers) no longer perturb the version. The coords-callback path keeps its own bump for directmesh.X.coordswrites. Both consumers (swarm solve-entry re-bin; snapshot validity) verified: gate 435 passed including test_0007, and the #382 deform-notification regression test still passes through the public path.Underworld development team with AI support from Claude Code