Skip to content

fix(mover): use a widely supported arrow for the Mover direction label - #2705

Open
Junker der Provinz (junkerderprovinz) wants to merge 1 commit into
unraid:masterfrom
junkerderprovinz:fix/mover-direction-arrow
Open

fix(mover): use a widely supported arrow for the Mover direction label#2705
Junker der Provinz (junkerderprovinz) wants to merge 1 commit into
unraid:masterfrom
junkerderprovinz:fix/mover-direction-arrow

Conversation

@junkerderprovinz

@junkerderprovinz Junker der Provinz (junkerderprovinz) commented Jul 27, 2026

Copy link
Copy Markdown

Fixes #2545.

The Mover direction options in Share Settings use (U+2B95), which is missing from many system fonts and renders as a tofu box. Replacing it with (U+2192), which is universally available, keeps the same meaning and renders everywhere.

The label is set via jQuery .text(), so a literal character is used rather than an HTML entity.

Summary by CodeRabbit

  • Style
    • Updated the “Mover action” direction indicator to use a simpler arrow symbol for improved visual consistency.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: da7f6885-d4d7-4c85-ac19-bf8d46cbd4d8

📥 Commits

Reviewing files that changed from the base of the PR and between 6d8c2cd and 09be4d3.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix/ShareEdit.page

Walkthrough

The Share settings mover direction dropdown replaces the glyph with across the affected transfer scenarios in updateScreen().

Changes

Mover Direction Labels

Layer / File(s) Summary
Update mover direction labels
emhttp/plugins/dynamix/ShareEdit.page
Mover direction option labels use the glyph in all affected transfer and preference branches.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A bunny hops through settings bright,
Replacing arrows left and right.
The mover’s path is clear to see,
With → guiding happily.
Carrots cheer: “A neat UI!”

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: replacing the Mover arrow with a widely supported character.
Linked Issues check ✅ Passed The PR replaces the illegible ⮕ glyph with → in Share Settings, satisfying #2545's direction-label fix.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to the ShareEdit.page arrow label and adds no unrelated behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mover Action Direction in Share Settings: illegible character to indicate the direction of Mover's action

1 participant