fix: clear clippy 1.96 drift + bump rustls-webpki (unblock CI) - #97
Merged
Conversation
Two pre-existing failures on main (toolchain + advisory-db drift) that block every PR: - crates/rpg-parser/build.rs: remove 3 unnecessary trailing commas in format! args (newer stable clippy flags them under -D warnings). - Cargo.lock: bump rustls-webpki 0.103.11 -> 0.103.13, resolving RUSTSEC-2026-0104 (reachable panic in CRL parsing) and RUSTSEC-2026-0099.
CI uses dtolnay/rust-toolchain@stable (now 1.96), which flags lints absent in older clippy. Resolve every workspace lint under -D warnings: - sort_by -> sort_by_key(Reverse(..)): graph.rs, cycles.rs, snapshot.rs, and the build.rs codegen for lang_registry. - unnecessary trailing commas in format! args: build.rs, tools.rs. - iterating a map's values: semantic_lifting.rs (file_index.values()). - collapsible match arm: deps.rs (method_call_expression only). - duration_suboptimal_units: provider.rs from_secs(120) -> from_mins(2). Also bump rustls-webpki 0.103.11 -> 0.103.13 (RUSTSEC-2026-0099/0104).
userFRM
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96.
CI uses
dtolnay/rust-toolchain@stable(now 1.96), whose clippy flags lints absent in older toolchains.mainis red on every PR. This clears all of them under-D warnings+ resolves the security advisories.Changes
unnecessary_sort_by→sort_by_key(Reverse(..)):rpg-core/graph.rs,rpg-nav/cycles.rs,rpg-nav/snapshot.rs, and therpg-parser/build.rscodegen forlang_registry.rs.unnecessary trailing commainformat!args:rpg-parser/build.rs,rpg-mcp/tools.rs.iterating on a map's values:rpg-encoder/semantic_lifting.rs(file_index.values()).rpg-parser/deps.rs(matchmethod_call_expressiononly; behaviour-preserving).duration_suboptimal_units:rpg-lift/provider.rsfrom_secs(120)→from_mins(2).rustls-webpki0.103.11 → 0.103.13 (RUSTSEC-2026-0099 + RUSTSEC-2026-0104, reachable panic in CRL parsing).Test plan
cargo +stable clippy --workspace --all-targets -- -D warnings(clean)cargo +stable fmt --all -- --checkcargo +stable test --workspace(all pass, 0 failed)cargo audit --ignore RUSTSEC-2025-0119 --ignore RUSTSEC-2024-0436 --ignore RUSTSEC-2026-0097(exit 0)