Skip to content

fix: sync fullscreen routes - #1608

Merged
domoritz merged 1 commit into
vega:masterfrom
oiahoon:fix/fullscreen-route-suffix
Jul 15, 2026
Merged

fix: sync fullscreen routes#1608
domoritz merged 1 commit into
vega:masterfrom
oiahoon:fix/fullscreen-route-suffix

Conversation

@oiahoon

@oiahoon oiahoon commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • append /view when fullscreen opens from the root or edited route
  • add valid application routes for /view and /edited/view
  • cover entering and exiting fullscreen from both routes with Playwright

Root cause

Fullscreen URL synchronization explicitly skipped / and /edited, and the router did not mount the application at their corresponding /view paths.

Validation

  • npx vitest --project unit (37 tests)
  • npx playwright test --project=chromium (84 tests)
  • npm run lint
  • npx tsc
  • npm run build
  • git diff --check

Closes #1508

@domoritz
domoritz requested a review from yuvvantalreja July 15, 2026 02:37
@domoritz
domoritz merged commit 44f19e1 into vega:master Jul 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fullscreen doesn't append '/view' to the current route

3 participants