fix(modules): guard regex extractor against negative group index#346
Open
TBX3D wants to merge 1 commit into
Open
fix(modules): guard regex extractor against negative group index#346TBX3D wants to merge 1 commit into
TBX3D wants to merge 1 commit into
Conversation
a module with a negative extractor group indexed matches[e.Group] past the lower bound, panicking the executor goroutine and crashing the whole scan. the existing bound only checked the upper end; check e.Group >= 0 too so an invalid group is skipped like an out-of-range one.
github-actions
Bot
added
size/s
pr summary2 files changed (+9 -1)
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage ? 54.72%
=======================================
Files ? 81
Lines ? 6874
Branches ? 0
=======================================
Hits ? 3762
Misses ? 2842
Partials ? 270 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a module's extractor group is a plain int sourced straight from its yaml definition, so a module setting group: -1 hit matches[-1] and panicked at runtime. skip negative groups instead of indexing into the match slice.