fix(scan): fetch wayback source over https#351
Open
TBX3D wants to merge 1 commit into
Open
Conversation
the wayback passive source used http while the crt.sh and certspotter sources use https. passive results flatten straight into findings, so an on-path attacker could tamper with the plaintext response to inject or strip historical urls. use https to match the other two sources.
github-actions
Bot
added
scan
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage ? 54.72%
=======================================
Files ? 81
Lines ? 6874
Branches ? 0
=======================================
Hits ? 3762
Misses ? 2842
Partials ? 270 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pr summary2 files changed (+18 -1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the wayback machine passive-recon feed was being fetched over plain http, so an on-path attacker able to tamper with the response could inject or drop subdomains/urls from what's meant to be a trusted enumeration source. switched the feed's base url to https, matching the other two passive sources (crt.sh, certspotter), and added a test pinning all three feeds to https.