refactor(fingerprint): make the favicon tech table the single source#358
Open
TBX3D wants to merge 2 commits into
Open
refactor(fingerprint): make the favicon tech table the single source#358TBX3D wants to merge 2 commits into
TBX3D wants to merge 2 commits into
Conversation
move the hash->tech map from internal/scan into internal/fingerprint beside the hash function, exposed as LookupFaviconTech. the scan Favicon path now resolves tech through it instead of a private map. drop the demo-sync guard test: it existed only to keep scan's map in sync with the yaml demo module, and that map no longer exists.
github-actions
Bot
added
size/m
pr summary7 files changed (+142 -86)
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage ? 54.74%
=======================================
Files ? 81
Lines ? 6881
Branches ? 0
=======================================
Hits ? 3767
Misses ? 2843
Partials ? 271 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
favicon module findings now read the tech straight from the shared fingerprint table, so a canonical hit reports "favicon mmh3=<n> tech=<name>" instead of a bare hash. unknown hashes are unaffected.
github-actions
Bot
added
size/l
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the shodan favicon-hash to tech-name table lived in internal/scan/favicon.go with a separate demo-sync test keeping it lined up against the favicon-*.yaml demo modules. moved it into internal/fingerprint as LookupFaviconTech so there's one table instead of two things that have to agree, and wired the module-side favicon evidence string to name the matched tech (favicon mmh3= tech=) instead of a bare hash.