Skip to content

feat(modules): add a range matcher for response size or status#362

Open
TBX3D wants to merge 1 commit into
vmfunc:mainfrom
TBX3D:feat/range-matcher
Open

feat(modules): add a range matcher for response size or status#362
TBX3D wants to merge 1 commit into
vmfunc:mainfrom
TBX3D:feat/range-matcher

Conversation

@TBX3D

@TBX3D TBX3D commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

the existing size matcher only checks exact-match against a list of values. this adds a range matcher type with inclusive min/max bounds over either the response/banner byte length (source: size, the default) or the http status code (source: status). an unbounded range, an inverted one (min > max), or an unknown source is rejected at load rather than silently never firing at match time.

the existing size matcher only checks exact-match against a list of values.
add a range matcher type with inclusive min/max bounds over either the
response/banner byte length (source: size, the default) or the http status
code (source: status). an unbounded or inverted range, or an unknown source,
is rejected at load rather than silently never firing at match time.
@TBX3D
TBX3D requested a review from vmfunc as a code owner July 9, 2026 23:45
@github-actions github-actions Bot added size/l <500 lines changed modules changes to scan modules tests test changes and removed size/l <500 lines changed labels Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

pr summary

4 files changed (+197 -10)

category files
go source 4
tests 1

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@7ea1cd2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/modules/executor.go 85.71% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage        ?   54.88%           
=======================================
  Files           ?       81           
  Lines           ?     6894           
  Branches        ?        0           
=======================================
  Hits            ?     3784           
  Misses          ?     2842           
  Partials        ?      268           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modules changes to scan modules tests test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants