fix: fall back to getRandomValues when crypto.randomUUID is unavailable - #6
Draft
Alex20923 wants to merge 1 commit into
Draft
fix: fall back to getRandomValues when crypto.randomUUID is unavailable#6Alex20923 wants to merge 1 commit into
Alex20923 wants to merge 1 commit into
Conversation
Alex20923
force-pushed
the
fix/crypto-randomuuid-insecure-context
branch
from
July 22, 2026 11:19
d1a4171 to
8a96d97
Compare
crypto.randomUUID() is only exposed in secure contexts (HTTPS or http://localhost). When SMDBox is served over plain HTTP on an IP address (e.g. straight from a JSON-RPC backend during development), crypto.randomUUID is undefined and invoking a method throws "TypeError: crypto.randomUUID is not a function" on submit, crashing the app. Add a randomUUID() helper that uses crypto.randomUUID when available and falls back to crypto.getRandomValues (which is exposed in insecure contexts too) otherwise. Route all six call sites through it and add unit tests covering the insecure-context fallback.
Alex20923
force-pushed
the
fix/crypto-randomuuid-insecure-context
branch
from
July 22, 2026 11:27
8a96d97 to
e43c291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto.randomUUID() is only exposed in secure contexts (HTTPS or http://localhost). When SMDBox is served over plain HTTP on an IP address (e.g. straight from a JSON-RPC backend during development), crypto.randomUUID is undefined and invoking a method throws
"TypeError: crypto.randomUUID is not a function" on submit, crashing the app.
Add a randomUUID() helper that uses crypto.randomUUID when available and falls back to crypto.getRandomValues (which is exposed in insecure contexts too) otherwise. Route all six call sites through it and add unit tests covering the insecure-context fallback.