Deflake modservice#5366
Open
jschaul wants to merge 4 commits into
Open
Conversation
zebot
added
the
ok-to-test
jschaul
marked this pull request as ready for review
July 23, 2026 11:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked at Flake News
And at some test failures that keep coming up.
Then I asked some AI to help me figure out what might be wrong. This PR is the result of multiple rounds of AI prompting. To my naive eye it looks like it could be an improvement to 50% flake probability status quo. But maybe I'm wrong. I'm sorry to ask you to review a small piece of AI-generated code, but the 50% flakiness is super annoying, alternatively feel free to close/reject this PR and then please find alternative ways to improve the flakiness.
Checklist
[ ] Add a new entry in an appropriate subdirectory ofchangelog.d