Free FP ECC cache in provider teardown#445
Open
ColtonWilley wants to merge 1 commit into
Open
Conversation
wc_ecc_free() doesn't release wolfCrypt's fixed-point ECC cache; call wc_ecc_fp_free() in wolfssl_prov_ctx_free() (guarded by FP_ECC).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wc_ecc_free()doesn't release wolfCrypt's fixed-point ECC cache (fp_cache[]), and nothing in wolfProvider callswc_ecc_fp_free()— so it's held for the process lifetime. Call it inwolfssl_prov_ctx_free(), guarded byFP_ECC.Frees the teardown thread's cache (thread-local under
HAVE_THREAD_LS); no-op when empty.