Skip to content

fix(dev): improve argument validation and fix filter typo in dev scripts #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alelpoan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(dev): improve argument validation and fix filter typo in dev scripts #2008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
087378e
fix(dev): add argument count validation in register-enable-node.sh
alelpoan May 26, 2026
f42fedc
fix(dev): add missing argument check in migration script
alelpoan May 26, 2026
0b724a5
fix(dev): correct pkg/mock filter typo in test script
alelpoan May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dev/cmd/register-enable-node.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
#!/usr/bin/env bash
set -euo pipefail

if [[ $# -ne 4 ]]; then
echo "Usage: $0 <owner_addr> <signer_pub> <http_addr> <config_file>"
echo "Example: $0 0x123... 0xabc... localhost:8080 config.yaml"
exit 1
fi
OWNER_ADDR="$1"
SIGNER_PUB="$2"
HTTP_ADDR="$3"
Expand Down
8 changes: 6 additions & 2 deletions dev/gen/migration
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,9 @@ set -e
script_dir=$(dirname "$(realpath "$0")")
repo_root=$(realpath "${script_dir}/../../")
cd "${repo_root}"

go tool -modfile=tools/go.mod migrate create -dir pkg/db/migrations -seq -digits=5 -ext sql "$1"
if [ -z "$1" ]; then
echo "Usage: $0 <migration_name>"
echo "Example: $0 add_user_balances_table"
exit 1
fi
go tool -modfile=tools/go.mod migrate create -dir pkg/db/migrations -seq -digits=5 -ext sql "$1"
2 changes: 1 addition & 1 deletion dev/test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -e
ulimit -n 2048

# shellcheck disable=SC2046 # word-split go list output so each package is its own arg
go test -timeout 30s $(go list ./... | grep -v -e 'pkg/abis' -e 'pkg/config' -e 'pkg/proto' -e 'pkg/mock' -e 'pkg/testing') "$@"
go test -timeout 30s $(go list ./... | grep -v -e 'pkg/abis' -e 'pkg/config' -e 'pkg/proto' -e 'pkg/mocks' -e 'pkg/testing') "$@"

if [ -n "${RACE:-}" ]; then
echo
Expand Down
Loading