ci: a Play track clear answers 200 with no body - #93
Merged
Conversation
put_track called r.json() on every 2xx, so the live promote died on its second PUT. Nothing had been committed, so Play was left untouched, but the promote could not finish. The stub always answered a PUT with a JSON body, which is why the suite missed it; it now models the body-less 200 and the old code fails against it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
enabled auto-merge (squash)
July 30, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearing a track answers 200 with an empty body, and
put_trackcalledr.json()on every 2xx, so the live promote of vc89 died between its two PUTs. Nothing had been committed at that point, so Play was left untouched and the tracks are exactly as they were, but the promote could not finish.The test stub always answered a PUT with a JSON body, which is why the suite missed this; it now models the body-less 200, and reverting the one-line fix makes the suite fail with the same
JSONDecodeErrorthe run produced.