chore(scripts): delete unused bench_abba_gpu.sh#812
Merged
Conversation
MauroToscano
added a commit
that referenced
this pull request
Jul 14, 2026
The bench-tooling dedup + bench_abba_gpu.sh removal are split into #812 so this PR is purely the cuda build-robustness changes (which want a GPU test run), leaving the trivial script cleanup free to merge independently.
Nothing invoked it — the GPU bench CI (/bench-gpu) runs bench_abba.sh, and the only reference was a stale comment. Its premise was also a mismatch: it wrapped the rigorous ABBA paired-t/Wilcoxon method around a GPU-on-vs-off question, where the effect is 10-40% and two runs settle it by eye. That machinery earns its keep only for the ~1% PR-vs-baseline deltas bench_abba.sh measures. Deleting it also resolves the duplicated-stats review finding on its own (the second copy is gone), so no shared-lib extraction is needed — bench_abba.sh keeps its self-contained stats.
MauroToscano
force-pushed
the
chore/bench-abba-cleanup
branch
from
July 14, 2026 16:30
303389c to
35f9156
Compare
MauroToscano
changed the title
Oppen
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
scripts/bench_abba_gpu.sh. One file, nothing else.Why
/bench-gpu) runsbench_abba.sh; the only remaining reference to the file was a stale comment.bench_abba.shmeasures.Deleting it also resolves the earlier "stats block duplicated between the two bench scripts" review finding by itself — with the second copy gone there's nothing to de-duplicate, so
bench_abba.shkeeps its self-contained stats and no shared helper is needed.Split out of #800 (cuda build robustness) since it's trivial and has no build/runtime surface.