Fix stale pending steer projection#804
Draft
brsbl wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The timeline treated any unaccepted steer as pending whenever the overall thread remained active. It did not distinguish thread activity from the lifecycle of the steer’s expected target turn. After durable request-settlement state was removed, a completed target with later unrelated active work could leave the old steer visible indefinitely.
Validation
pnpm exec turbo run test --filter=@bb/thread-view --force— 343 tests passedpnpm exec turbo run test --filter=@bb/server --force -- test/services/threads/timeline-parented-pagination.test.ts— 3 tests passedpnpm exec turbo run typecheck --filter=@bb/thread-view --forcepnpm exec turbo run typecheck --filter=@bb/server --force