Replace instances of NiDS controllers in examples - #294
Merged
Conversation
sciencewhiz
force-pushed
the
NiDSExamples
branch
from
July 25, 2026 23:11
e0adae0 to
f182b35
Compare
sciencewhiz
force-pushed
the
NiDSExamples
branch
from
July 25, 2026 23:25
f182b35 to
4681cc0
Compare
sciencewhiz
marked this pull request as ready for review
July 26, 2026 01:30
Member
|
Don't the upstream examples need to be updated too? |
Contributor
Author
|
By upstream you mean C++/Java? They were updated to not use the NiDS classes a while ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.